Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fetching MAC address table in junos #895

Merged
merged 2 commits into from
Dec 23, 2018
Merged

Fix fetching MAC address table in junos #895

merged 2 commits into from
Dec 23, 2018

Conversation

jobec
Copy link
Contributor

@jobec jobec commented Dec 21, 2018

Fixes #894

@jobec
Copy link
Contributor Author

jobec commented Dec 21, 2018

This still needs some more real-world testing

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 80.267% when pulling 77b74e0 on jobec:fix_junos_mac_table_on_srx300 into b54f269 on napalm-automation:develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 80.267% when pulling 77b74e0 on jobec:fix_junos_mac_table_on_srx300 into b54f269 on napalm-automation:develop.

@coveralls
Copy link

coveralls commented Dec 21, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.01%) to 80.217% when pulling 20bb16c on jobec:fix_junos_mac_table_on_srx300 into b54f269 on napalm-automation:develop.

@jobec jobec changed the title [WIP] Fix fetching MAC address table in junos Fix fetching MAC address table in junos Dec 21, 2018
@jobec
Copy link
Contributor Author

jobec commented Dec 21, 2018

This is ready for merge.

Tested on all sorts of EX, MX, SRX and QFX systems and different junos versions.

@mirceaulinic mirceaulinic added this to the 2.3.6 milestone Dec 23, 2018
mirceaulinic
mirceaulinic approved these changes Dec 23, 2018
View reviewed changes
Copy link
Member

@mirceaulinic mirceaulinic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jobec

@mirceaulinic mirceaulinic merged commit 05f9fbb into napalm-automation:develop Dec 23, 2018
@jobec jobec deleted the fix_junos_mac_table_on_srx300 branch December 25, 2018 11:02
ExaneServerTeam pushed a commit to ExaneServerTeam/napalm that referenced this pull request Mar 6, 2020
@jobec @ExaneServerTeam
Fix fetching MAC address table in junos (napalm-automation#895)
8250286 
* Fix fetching MAC address table in junos

* Handle a disabled L2 subsystem
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirceaulinic mirceaulinic mirceaulinic approved these changes

Assignees
No one assigned
Labels
bug junos
Projects
None yet
Milestone
2.3.6
Development

Successfully merging this pull request may close these issues.
3 participants
@jobec @coveralls @mirceaulinic