Update deploy_docs.yml to use metadata to use proper napari version substitution #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jni
approved these changes
Feb 11, 2023
Czaki
approved these changes
Feb 11, 2023
Merged
9 tasks
psobolewskiPhD
added a commit
to napari/napari
that referenced
this pull request
Feb 14, 2023
…stitutions (#5557) # Description This PR an an analog to napari/docs#99 The built docs built by this repo PR action have improper napari version substitution (see napari/docs#51) This PR fixes that based on the README of https://github.com/actions/checkout It updates the deploy action with `fetch-depth: 0`. You can see that this was added to the napari/docs PR build_docs action and works correctly. This makes the version metadata be correct (see pypa/setuptools-scm#480) ## Type of change - [x] Bug-fix (non-breaking change which fixes an issue) # References Motivated by napari/docs#51 Analog to napari/docs#99
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See napari/napari#5509 (comment)
The docs live on napari.org don't match PR action downloaded docs when doing napari version substitution (#51)
Live, napari.org docs:
PR built docs, download zip:
This PR updates the deploy action with
fetch-depth: 0that was added to the PRbuild_docsaction. This should make the version metadata be correct (see pypa/setuptools-scm#480)Type of change
References
Adresses issue noted here napari/napari#5509 (comment)
Final checklist:
I'm not sure how to test this or check that it's correct, because the issue is already fixed in PR builds.