Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track is multi output #1855

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

MarcoGorelli
Copy link
Member

One step closer to #1780.

Next steps:

  • in the metadata, store a callable which determines the root names
  • only set aliases when necessary, as opposed to renaming after each operation. PySpark / SQL don't let us set as many aliases as we do now, e.g. 'select (a - mean(a) over () as a) as a from rel' raises

What type of PR is this? (check all applicable)

  • 💾 Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 🔧 Optimization
  • 📝 Documentation
  • ✅ Test
  • 🐳 Other

Related issues

  • Related issue #<issue number>
  • Closes #<issue number>

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below

Comment on lines +371 to +372
if isinstance(arg, str):
# Column name, e.g. 'a', gets treated as `nw.col('a')`,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sigh...this isn't even always true. darn. we may need to parse column names as expressions a bit earlier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant