Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patch: fix duckdb narwhals_to_native_dtype for Int32 and UInt32 #1857

Merged
merged 1 commit into from
Jan 24, 2025
Merged

patch: fix duckdb narwhals_to_native_dtype for Int32 and UInt32 #1857

merged 1 commit into from
Jan 24, 2025
+5 −4

Conversation

FBruzzesi
Copy link
Member

What type of PR is this? (check all applicable)

  • 💾 Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 🔧 Optimization
  • 📝 Documentation
  • ✅ Test
  • 🐳 Other

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below

@FBruzzesi FBruzzesi added the duckdb Issue is related to duckdb backend label Jan 23, 2025
MarcoGorelli
MarcoGorelli approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @FBruzzesi !

@MarcoGorelli MarcoGorelli merged commit 03056f5 into main Jan 24, 2025
23 of 24 checks passed
@MarcoGorelli MarcoGorelli deleted the fix/duckdb-cast-to-integer branch January 24, 2025 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees
No one assigned
Labels
duckdb Issue is related to duckdb backend fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FBruzzesi @MarcoGorelli