Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh: Deprecate native_namespace in favour of backend in from_dict #1931

Merged
merged 18 commits into from
Feb 4, 2025

Conversation

raisadz
Copy link
Contributor

@raisadz raisadz commented Feb 4, 2025

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • ✨ Feature
  • πŸ› Bug Fix
  • πŸ”§ Optimization
  • πŸ“ Documentation
  • βœ… Test
  • 🐳 Other

Related issues

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below

dangotbanned added a commit to dangotbanned/narwhals that referenced this pull request Feb 4, 2025
New API can start without deprecations, related narwhals-dev#1931
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks for doing all the v1 things!

just added a really minor commit to factor of validating backend and native_namespace, as we'll use that in other functions too later

@MarcoGorelli MarcoGorelli marked this pull request as ready for review February 4, 2025 17:24
@MarcoGorelli MarcoGorelli added the enhancement New feature or request label Feb 4, 2025
@MarcoGorelli MarcoGorelli merged commit 71a5bc5 into narwhals-dev:main Feb 4, 2025
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate native_namespace in favour of backend in IO functions
2 participants