Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves docker stuff from deploy into build #247

Merged
merged 5 commits into from
Dec 3, 2024

Conversation

dakota002
Copy link
Collaborator

No description provided.

@dakota002
Copy link
Collaborator Author

Working on fixing build errors

@dakota002
Copy link
Collaborator Author

@lpsinger Should I also update the line:
type=raw,value=latest,enable=${{ matrix.env == 'dev' }}

to the way that we do it in the gcn-monitor as well:
type=raw,value=latest,enable=${{ github.ref == format('refs/heads/{0}', github.event.repository.default_branch) }}

@lpsinger
Copy link
Member

lpsinger commented Dec 2, 2024

Yes.

@lpsinger lpsinger merged commit bfd1d57 into nasa-gcn:main Dec 3, 2024
3 checks passed
@dakota002 dakota002 deleted the MergeDeployIntoBuild branch December 3, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants