You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The function names in the unit test code are absurdly verbose. Some of these unit test function names are 150+ characters in length (exceeding the clang-format line length limit on their own!).
This could be considered coding style, but this is so excessive that it warrants pruning them all back - Note that for portability, symbol names should ideally be kept under 32 significant characters. This is per ISO STD C9899 section 5.2.4.1 - This says that an implementation is only required to recognize 31 significant chars on an external symbol name, or 63 on a local symbol name. The fact that this goes so far beyond the c99-specified limits is a good reason to fix it.
The function names in the unit test code are absurdly verbose. Some of these unit test function names are 150+ characters in length (exceeding the clang-format line length limit on their own!).
This could be considered coding style, but this is so excessive that it warrants pruning them all back - Note that for portability, symbol names should ideally be kept under 32 significant characters. This is per ISO STD C9899 section 5.2.4.1 - This says that an implementation is only required to recognize 31 significant chars on an external symbol name, or 63 on a local symbol name. The fact that this goes so far beyond the c99-specified limits is a good reason to fix it.
Example:
CF/unit-test/cf_cfdp_s_tests.c
Line 1224 in a894069
Descriptive content on what the test is supposed to do belongs in comments, not within the function name itself.
The text was updated successfully, but these errors were encountered: