-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up commented-out functions in unit test #102
Comments
a7f89be was never merged, reopening since there's still many commented out sections in CF unit tests. |
Looks like there's still a few stray lines of commented out code that need to get resolved. Note our coding standard discourages using the C++ style comments to begin with (no
|
2 tasks
@thnkslprpt Yes, looks good! |
dzbaker
added a commit
that referenced
this issue
Oct 18, 2022
Fix #102, Clean up remaining commented-out code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The unit test contains a number of test sequences that are completely disabled/commented out.
For example:
CF/unit-test/cf_cfdp_r_tests.c
Lines 1841 to 1876 in 7b99b91
These serve no value, they are not testing anything, and only serve to clutter the code (it is not likely to work if un-commented, as it would be un-commented already if it did work).
Without a clear reason why these exist in the code, recommendation is to remove. Version control serves the purpose of preserving historical code, if the concern is to keep a historical record of a previous test case (it does not need to stay in source file).
The text was updated successfully, but these errors were encountered: