Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MCP750/VxWorks typos + minor bugs #443

Open
2 tasks done
thnkslprpt opened this issue Dec 11, 2024 · 0 comments · May be fixed by #444
Open
2 tasks done

MCP750/VxWorks typos + minor bugs #443

thnkslprpt opened this issue Dec 11, 2024 · 0 comments · May be fixed by #444

Comments

@thnkslprpt
Copy link
Contributor

Checklist

  • I reviewed the Contributing Guide.
  • I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
There area few typos and minor bugs in the VxWorks PSP layer.
e.g. reset-type/sub-type:

else if (reset_register & SYS_REG_BLRR_PBRST)
{
OS_printf("CFE_PSP: POWERON Reset: CPCI Push Button Reset.\n");
reset_type = CFE_PSP_RST_TYPE_POWERON;
reset_subtype = CFE_PSP_RST_SUBTYPE_PUSH_BUTTON;
}
else if (reset_register & SYS_REG_BLRR_FBTN)
{
OS_printf("CFE_PSP: POWERON Reset: Front Panel Push Button Reset.\n");
reset_type = CFE_PSP_RST_SUBTYPE_PUSH_BUTTON;
reset_subtype = 3;
}
else if (reset_register & SYS_REG_BLRR_WDT2)
{
OS_printf("CFE_PSP: PROCESSOR Reset: Watchdog level 2 Reset.\n");
reset_type = CFE_PSP_RST_TYPE_PROCESSOR;
reset_subtype = CFE_PSP_RST_SUBTYPE_HW_WATCHDOG;

GetModuldIdFunc missing the 'e' in 'Module:

int32 CFE_PSP_GetCFETextSegmentInfo(cpuaddr *PtrToCFESegment, uint32 *SizeOfCFESegment)
{
int32 return_code;
STATUS status;
MODULE_ID cFEModuleId;
MODULE_INFO cFEModuleInfo;
cpuaddr GetModuleIdAddr;
MODULE_ID (*GetModuldIdFunc)(void);

Expected behavior
Correct for clarity-sake.

Reporter Info
Avi Weiss   @thnkslprpt

thnkslprpt added a commit to thnkslprpt/PSP that referenced this issue Dec 11, 2024
thnkslprpt added a commit to thnkslprpt/PSP that referenced this issue Dec 11, 2024
@thnkslprpt thnkslprpt linked a pull request Dec 11, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant