Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command Code/Enum naming convention inconsistencies #87

Closed
2 tasks done
thnkslprpt opened this issue Apr 17, 2023 · 0 comments · Fixed by #88
Closed
2 tasks done

Command Code/Enum naming convention inconsistencies #87

thnkslprpt opened this issue Apr 17, 2023 · 0 comments · Fixed by #88

Comments

@thnkslprpt
Copy link
Contributor

Checklist

  • I reviewed the Contributing Guide.
  • I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug

  • Similar to LC issue: Correct naming convention inconsistencies LC#70
    • SC also has a few command code macros that are not consistent with the enumeration identifiers or the command function name (all are cases of 2 words being combined into 1).

Code snips
SC_StartRtsGrpCmd()
SC_START_RTSGRP_CC (should be SC_START_RTS_GRP_CC)

SC_EnableRtsGrpCmd()
SC_ENABLE_RTSGRP_CC (should be SC_ENABLE_RTS_GRP_CC)

...and a couple more.

Expected behavior
Identifiers should conform to the cFS/cFE naming convention with regard to consistent use of underscores to make mnemonics clear and readable.

Reporter Info
Avi Weiss @thnkslprpt

thnkslprpt added a commit to thnkslprpt/SC that referenced this issue Apr 17, 2023
dzbaker added a commit that referenced this issue Jun 1, 2023
…erscores-for-consistency

Fix #87, Update Command Code underscores for consistency
@dmknutsen dmknutsen added this to the Equuleus milestone Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants