Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate with current OSAL version #165

Closed
jphickey opened this issue Oct 4, 2022 · 0 comments · Fixed by #174
Closed

Integrate with current OSAL version #165

jphickey opened this issue Oct 4, 2022 · 0 comments · Fixed by #174
Assignees
Labels
enhancement New feature or request

Comments

@jphickey
Copy link
Collaborator

jphickey commented Oct 4, 2022

The latest OSAL mainline has support for condition variables and therefore should support all BPLib requirements of the OS.

The embedded "os" calls at https://github.com/nasa/bplib/blob/main/inc/bplib_os.h should be mapped to the corresponding OSAL function. This would largely replace/supplant the existing cfe.c implementation.

The direct POSIX mapping in posix.c could be retained or removed. If removed, there would be a hard dependency on OSAL and all test programs would also have to be built and linked with OSAL. If preserved, it could simplify certain functional test workflows as the software could then be built on Linux with no external dependencies required. However, this could only simplify certain functional/black box tests. For coverage testing, the OSAL-based build would be required as this provides UT assert as well as coverage stub frameworks.

@jphickey jphickey self-assigned this Oct 4, 2022
@jphickey jphickey added the enhancement New feature or request label Oct 4, 2022
jphickey added a commit to jphickey/bplib that referenced this issue Oct 12, 2022
Utilize NASA OSAL (https://github.com/nasa/osal) as the preferred option
for OS abstraction.  The "bplib_os" calls become simple wrappers around
OSAL functions.

The OSAL package also provides UT assert and stub framework that can be
used for unit testing.
jphickey added a commit to jphickey/bplib that referenced this issue Oct 17, 2022
Utilize NASA OSAL (https://github.com/nasa/osal) as the preferred option
for OS abstraction.  The "bplib_os" calls become simple wrappers around
OSAL functions.

The OSAL package also provides UT assert and stub framework that can be
used for unit testing.
jphickey added a commit that referenced this issue Oct 25, 2022
Fix #121, #165, OSAL integration and initial coverage tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant