Fix #214, resolve build error with CFS and tests #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not build the sanity checks when part of a CFS build, as this does not link properly due to the different linking environment. The sanity checks only work in a standalone bplib build.
jphickey
force-pushed
the
fix-214-cfs-build
branch
from
b373cee to
88815b1
Compare
|
Approved. |
karl-nasa
approved these changes
Nov 23, 2022
glan6388
approved these changes
Nov 24, 2022
jphickey
added
ccb:ready
|
Reviewed and approved at 2022-11-30 CCB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Do not build the sanity checks when part of a CFS build, as this does not link properly due to the different linking environment. The sanity checks only work in a standalone bplib build.
Fixes #214
Testing performed
Build in CFS
Expected behavior changes
Build now succeeds
System(s) tested on
Ubuntu 22.04
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.