Fix #175, implement bplib v7 Coverage Test Cases #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jphickey
approved these changes
Nov 30, 2022
There was a problem hiding this comment.
Looks good! This significantly improves the coverage level. Still more work to do, but this is a big step in the right direction.
I'd like to tackle #216 next and then we can get back to looking at coverage of the smaller pieces.
glan6388
added
ccb:approved
|
Reviewed and approved at 2022-11-30 CCB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Implement test cases to cover v7 implementation. .
Fix #175
Testing performed
Build and run tests, line coverage is 50%+
Expected behavior changes
Coverage test is partial implemented
System(s) tested on
CentOS 7
Contributor Info - All information REQUIRED for consideration of pull request
George Lan, MCSG Technologies.