Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #182, add workflow coverage test #222

Closed
wants to merge 1 commit into from

Conversation

glan6388
Copy link
Collaborator

@glan6388 glan6388 commented Dec 5, 2022

Describe the contribution
Added Workflow Coverage Test files for bplib

Testing performed
CentOS 7

Expected behavior changes
Auto Run coverage test in github

System(s) tested on
CentOS 7

Contributor Info - All information REQUIRED for consideration of pull request
George Lan
MCSG Technologies

@glan6388 glan6388 changed the title workflow coverage test fix #182, add workflow coverage test Dec 5, 2022
@glan6388 glan6388 requested a review from jphickey December 5, 2022 22:44
@jphickey
Copy link
Collaborator

jphickey commented Dec 7, 2022

I actually don't think we need to re-run coverage as a separate workflow, because coverage results are already being reported in the build/run workflow.

However, I would like to see minimum coverage enforcement (that is, the workflow will fail if a PR makes the number of uncovered lines/branches go up). This can catch cases where a developer makes a new feature/fix but forgets to update the test accordingly - happens frequently!

I believe OSAL and CFE both do this so there should be examples of how it can be checked.

@glan6388 glan6388 closed this Dec 13, 2022
@glan6388 glan6388 deleted the fix-182-coverage_workflow branch July 15, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants