Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use TblName in TBL reporting when available #1506

Open
skliper opened this issue May 12, 2021 · 0 comments · May be fixed by #2179
Open

Use TblName in TBL reporting when available #1506

skliper opened this issue May 12, 2021 · 0 comments · May be fixed by #2179

Comments

@skliper
Copy link
Contributor

skliper commented May 12, 2021

Is your feature request related to a problem? Please describe.
Inconsistent reporting of table "context" throughout CFE_TBL_Register (and likely others).

Just 'Name' (no app) example:

CFE_ES_WriteToSysLog("CFE_TBL:Register-Table %s has size of zero\n", Name);

No table context at all:

CFE_ES_WriteToSysLog(
"CFE_TBL:Register-1st Buf Alloc GetPool fail Stat=0x%08X MemPoolHndl=0x%08lX\n",
(unsigned int)Status, CFE_RESOURCEID_TO_ULONG(CFE_TBL_Global.Buf.PoolHdl));

Re-assembled name:

CFE_ES_WriteToSysLog(
"CFE_TBL:Register-Failed to get work buffer for '%s.%s' (ErrCode=0x%08X)\n",
AppName, Name, (unsigned int)Status);

Actual TblName use:

CFE_ES_WriteToSysLog(
"CFE_TBL:Register-Attempt to register existing table ('%s') with different size(%d!=%d)\n",
TblName, (int)Size, (int)RegRecPtr->Size);

Describe the solution you'd like
Just use TblName, it's assembled right at the start. Consistent syslog format (see also #1325) of "function: TblName - message" or similar.

Describe alternatives you've considered
None

Additional context
Code review

Requester Info
Jacob Hageman - NASA/GSFC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant