Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2233, Update data types in CFE msgs #2234

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

havencarlson
Copy link
Contributor

Checklist (Please check before submitting)

Describe the contribution
Fix #2233, Changed data types of some fields in certain message packets

Testing performed
Unit Testing

Expected behavior changes
no impact to behavior

System(s) tested on

  • OS: Ubuntu 18.04

Contributor Info - All information REQUIRED for consideration of pull request
Haven Carlson - NASA

@havencarlson havencarlson marked this pull request as draft December 23, 2022 22:49
Copy link
Contributor

@skliper skliper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks to me like some of these would get padding added by the compiler?

@dmknutsen
Copy link
Contributor

Agreed - I just double checked and the intent was to update the EDS files to match FSW/the current database such that everything is in sync.

@dmknutsen dmknutsen added refactor invalid CCB:Ignore Pull Request can be ignored. Will be re-examined at by next CCB. and removed invalid refactor labels Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Ignore Pull Request can be ignored. Will be re-examined at by next CCB.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data type changes
3 participants