-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CUMULUS-3859:Update @cumulus packages and elasticsearch removal #1155
Conversation
PR Feedback: When I run the Cypress integration tests in Electron 93, I get errors. I think these are based on code being changed in the components and not being updated in the tests, but I'll send this back to you to make sure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTG! @jennyhliu
Summary: Summary of changes
Addresses CUMULUS-3859: cumulus-dashboard: Update @cumulus packages for cypress tests
Changes
@cumulus/[email protected]
and@cumulus/[email protected]
Previously, api list endpoints searches record from ElasticSearch, and the ES records inserted for testing have the recent timestamp/updatedAt, so when the
datepicker
is set toRecent
, the records will returned.With @cumulus/api > 19.1.0, api list endpoints search pg records, and the records inserted into pg have the original timestamp/updated_at, in order to test
Recent
datepicker, we adjust cy.clock(), so that records can be returned.Issues after update packages
Error: Package subpath './lib/utils' is not defined by "exports" in /data/bamboo/bamboo-agent-home/xml-data/build-dir/CUM-CDG251-TEST/cumulus-dashboard/node_modules/cheerio/package.json
solution: Get an Error About export cheeriojs/cheerio#2547 lock cheerio version to 1.0.0-rc.12
npm run serve
WARNING in ./node_modules/asn1.js/lib/asn1/api.js 21:12-42
Module not found: Error: Can't resolve 'vm' in '/Users/jhliu/cumulus-dashboard/node_modules/asn1.js/lib/asn1'
BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
This is no longer the case. Verify if you need this module and configure a polyfill for it.
If you want to include a polyfill, you need to:
- add a fallback 'resolve.fallback: { "vm": require.resolve("vm-browserify") }'
- install 'vm-browserify'
If you don't want to include a polyfill, you can use an empty module like this:
resolve.fallback: { "vm": false }
PR Checklist