Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Posix implementation comments refer to old time APIs, update to OS_GetLocalTime and OS_SetLocalTime #1177

Closed
thesamprice opened this issue Oct 6, 2021 · 0 comments · Fixed by #1178 or #1191
Closed

Posix implementation comments refer to old time APIs, update to OS_GetLocalTime and OS_SetLocalTime #1177

thesamprice opened this issue Oct 6, 2021 · 0 comments · Fixed by #1178 or #1191
Labels
docs draco-rc1
Milestone
Draco

Comments

@thesamprice
Copy link

Describe the bug
A clear and concise description of what the bug is.

OS_GetLocalTime
src/os/portable/os-impl-posix-gettime.c: * This file contains implementation for OS_GetTime() and OS_SetTime()
Update comment to OS_GetLocalTime / OS_SetLocalTime

To Reproduce
Steps to reproduce the behavior:
git grep OS_GetTime

Expected behavior
A clear and concise description of what you expected to happen.

Additional context
Add any other context about the problem here.

Reporter Info
Sam Price
thesamprice pushed a commit to thesamprice/osal that referenced this issue Oct 7, 2021
Fix nasa#1177 Rename OS_XXXTime to OS_XXXLocalTime in comments.
5cba5ae
@skliper skliper changed the title OS_GetLocalTime Posix implementation comments refer to old time APIs, update to OS_GetLocalTime and OS_SetLocalTime Oct 28, 2021
@skliper skliper mentioned this issue Oct 28, 2021
Merged
@skliper skliper added the docs label Oct 28, 2021
@skliper skliper added this to the Draco milestone Oct 28, 2021
astrogeco added a commit to astrogeco/osal that referenced this issue Nov 3, 2021
@astrogeco
Merge pull request nasa#1178 from thesamprice/1177-OSTimeComment
379f19f 
Fix nasa#1177 Rename OS_XXXTime to OS_XXXLocalTime in comments
@astrogeco astrogeco mentioned this issue Nov 3, 2021
Merged
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@skliper
Fix nasa#1177, Update version description per current design
5394484
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@astrogeco
Merge pull request #1603 from skliper/fix1177-mission_rev_doc
948a192 
Fix nasa#1177, Update version description per current design
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs draco-rc1
Projects
None yet
Milestone
Draco
2 participants
@thesamprice @skliper