Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommended lgtm osal issues #327

Closed
avan989 opened this issue Dec 20, 2019 · 2 comments · Fixed by #633 or #639
Closed

Recommended lgtm osal issues #327

avan989 opened this issue Dec 20, 2019 · 2 comments · Fixed by #633 or #639
Assignees
Milestone

Comments

@avan989
Copy link
Contributor

avan989 commented Dec 20, 2019

Is your feature request related to a problem? Please describe.
Recommended osal issues:

osapi-os-core.h

line 50:
/* #define for enabling floating point operations on a task*/
--
  | This comment appears to contain commented-out code

osapi-module.c

line 319:
/* module_prop->creator = record->creator; */
--
  | This comment appears to contain commented-out code


shared/os-impl.h

typedef enum
--
367 | {
  | In an enumerator list, the = construct should not be used to explicitly initialize members other than the first, unless all items are explicitly initialized.
368 | OS_FILE_FLAG_NONE,
369 | OS_FILE_FLAG_CREATE = 0x01,

posix/osnetwork.c

/*
--
25 | * FIXME: this belongs in the osconfig.h file, really.
26 | */
  | FIXME comment: this belongs in the osconfig.h file, really.
27 | #define OS_NETWORK_SUPPORTS_IPV6

shared/osapi-select.c

/*
--
85 | * FIXME:
86 | * This does not currently increment any refcounts.
87 | * That means a file/socket can be closed while actively inside a
88 | * OS_SelectMultiple() call in another thread.
89 | */
  | FIXME comment

Requester Info
Anh Van, NASA Goddard

@avan989 avan989 changed the title Recommended osal issues Recommended lgtm osal issues Dec 20, 2019
@skliper
Copy link
Contributor

skliper commented Dec 22, 2019

Moved #include of c files to #285

@skliper
Copy link
Contributor

skliper commented Oct 22, 2020

FIXME moved to #630

skliper added a commit to skliper/osal that referenced this issue Oct 22, 2020
skliper added a commit to skliper/osal that referenced this issue Oct 22, 2020
skliper added a commit to skliper/osal that referenced this issue Oct 22, 2020
astrogeco added a commit that referenced this issue Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants