-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for object id inline functions #982
Comments
Initial brainstorming thoughts: I think that would cover it... EDIT: Whoops, there may not be a FromArrayIndex... may just need to create all the ID's (seems like overkill, but I'm not sure how else to get the max. Maybe there is a coverage test utility to do the conversion? Could just keep creating them until it errors, then check the max (converted) index against the maximum configured value. |
This cuts the number of logged test cases from nearly 80k to about 580.
This cuts the number of logged test cases from nearly 80k to about 580.
This cuts the number of logged test cases from nearly 80k to about 580.
Fix #982, Add test for object id inline functions
This cuts the number of logged test cases from nearly 80k to about 580.
Define a data structure in cfe_sb_msg.h that will be used with the "write pipe info" command (CFE_SB_SEND_PIPE_INFO_CC). This allows the internal CFE_SB_PipeD_t descriptor object to evolve as needed without affecting the binary format of the file that is generated form this command, and items such as memory pointers may be excluded from the file.
Fix nasa#982, separate pipeinfo file data structure
Is your feature request related to a problem? Please describe.
OS_ObjectIdToInteger
,OS_ObjectIdFromInteger
,OS_ObjectIdEqual
,OS_ObjectIdDefined
are missing tests.Describe the solution you'd like
Add tests.
Since these are inline they can be completely exercised via explicit coverage tests (suggest adding to coveragetest-idmap.c).
Note these can be trivial, just need to convert a to and from a range of ID's (note these are just to/from integers, NOT indexes...), check each for equal to itself but not equal to the others, check that OS_OBJECT_ID_UNDEFINED results in undefined and the rest are defined. This also ensures an ID didn't "wrap" by exercising Array Index conversions from array index 0 and max for each type (as defined in configuration).
Describe alternatives you've considered
Could be added to a "functional/full stack" test but no point since they don't have any external dependencies.
Additional context
None
Requester Info
Jacob Hageman - NASA/GSFC
The text was updated successfully, but these errors were encountered: