Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't push perf stats on branches other than master #2371

Closed

Conversation

herwinw
Copy link
Member

@herwinw herwinw commented Dec 4, 2024

This should fix the second issue of #2369.

@herwinw herwinw linked an issue Dec 4, 2024 that may be closed by this pull request
@herwinw herwinw force-pushed the ci_perf_only_push_master branch from fcfd93a to 55be48f Compare December 4, 2024 06:16
@herwinw herwinw marked this pull request as ready for review December 4, 2024 06:16
@seven1m
Copy link
Member

seven1m commented Dec 4, 2024

My intention was to create a web page where one could compare a recent branch to master. Thoughts?

@seven1m
Copy link
Member

seven1m commented Dec 7, 2024

I think I want to give the web page idea a try at least. I think it'd be cool to be able to compare a branch to master and to itself over time, if it's something I'm actively working on. And I'll make a cleanup task that deletes old branch stats so they don't clutter up over time.

@seven1m seven1m closed this Dec 7, 2024
@herwinw herwinw deleted the ci_perf_only_push_master branch December 13, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Limit performance test uploads to branch master with the stats key
2 participants