Fix ASAN tests #2377
Merged
Fix ASAN tests #2377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, this wasn't working as intended. The build was the release build, so most of the code wasn't compiled with the sanitizer enabled. :-(
I've pared this down to just two of the example scripts that complete with AddressSanitizer enabled.
seven1m
force-pushed
the
better-asan-test
branch
from
7e5b216 to
db3a7dd
Compare
seven1m
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
docker_test_asantask was broken -- it wasn't actually building Natalie correctly.This is a step backwards, but it's more true to reality.