-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the option to save all temperature profiles in a climate run #215
base: dev
Are you sure you want to change the base?
Conversation
Awesome!!! @aditya-sengupta could you do me a favor and submit the PR to dev, not master! Sorry I didn't mention that before! You should be able to edit this existing PR's base merge to dev easily Also great questions about the paths. Currently the docs are built on a machine at nasa. I run all the notebooks during the build to ensure proper functionality of all parts before it goes live. Usually for file creation during a tutorial I just have it created in the same working directory for simplicity, then add the filetype to .gitignore. I think h5 files should already be ignored anyways. |
Noticed the 1D -> 2D change broke the convergence animation so added a fix for that |
Now saves to HDF5 whenever Currently |
Closes #213.
picaso/data/...
on my machine; I could change this back but am not sure how to make the path work as it was. Is there a project convention to make paths starting with /data work, such as having /path/to/picaso in sys.path?all_profiles
flattened the array of temperature profiles so that it was a 1D array of length (niter * npoints,). Changed this to be a 2D array (niter, npoints) and changedappend
calls tovstack
to accommodate this. This means we can read the temperature profile at each iteration from the HDF5 file without needing to calculate indices for where each one starts.