Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HRA summary statistics table not producing correct outputs #1080

Closed
phargogh opened this issue Sep 10, 2022 · 0 comments · Fixed by #1083
Closed

HRA summary statistics table not producing correct outputs #1080

phargogh opened this issue Sep 10, 2022 · 0 comments · Fixed by #1083
Assignees
@phargogh
Labels
bug Something isn't working in progress This issue is actively being worked on
Milestone
3.12.1

Comments

@phargogh
Copy link
Member

Jade reported that the 3.12.0 version of HRA doesn't produce correct outputs for the percentages of risk classifications for HIGH, MEDIUM, and LOW (R_%{HIGH,MEDIUM,LOW}). I have confirmed that this is an issue on the Belize inputs that Jade sent me.

The summary statistics table function is pretty complicated and could be greatly simplified once natcap/pygeoprocessing#270 is implemented.
@phargogh phargogh added bug Something isn't working in progress This issue is actively being worked on labels Sep 10, 2022
@phargogh phargogh self-assigned this Sep 10, 2022
phargogh added a commit to phargogh/invest that referenced this issue Sep 10, 2022
@phargogh
Reimplementing SUMMARY_STATISTICS.csv to use zonal_statistics.
b9dcc68 
RE:natcap#1080
phargogh added a commit to phargogh/invest that referenced this issue Sep 10, 2022
@phargogh
Fixing a few bugs in the table creation step.
a4c59db 
RE:natcap#1080
phargogh added a commit to phargogh/invest that referenced this issue Sep 10, 2022
@phargogh
Adding a %NONE field for no risk.
76ecd5a 
Adding this field seems right because it means we can make sure all 4 of
the fields add up to 100%. RE:natcap#1080
phargogh added a commit to phargogh/invest that referenced this issue Sep 10, 2022
@phargogh
Removing no-longer-used functions.
0d94a8b 
RE:natcap#1080
phargogh added a commit to phargogh/invest that referenced this issue Sep 15, 2022
@phargogh
Using in-development value_counts pygeoprocessing branch. RE:natcap#1080
9aeb56e
phargogh added a commit to phargogh/invest that referenced this issue Sep 15, 2022
@phargogh
Adding docstring for new stats table function. RE:natcap#1080
765ca7a
phargogh added a commit to phargogh/invest that referenced this issue Sep 15, 2022
@phargogh
Rewriting explicit dict creation with comprehensions. RE:natcap#1080
9bbccb4
phargogh added a commit to phargogh/invest that referenced this issue Sep 15, 2022
@phargogh
Minor comment and linting. RE:natcap#1080
f1b7d3d
phargogh added a commit to phargogh/invest that referenced this issue Sep 15, 2022
@phargogh
Fixing a few issues that came up in tests.
b7730a1 
Mostly just division by zero or missing keys. RE:natcap#1080
phargogh added a commit to phargogh/invest that referenced this issue Sep 15, 2022
@phargogh
Removing a test that's no longer needed. RE:natcap#1080
bd91d26
phargogh added a commit to phargogh/invest that referenced this issue Sep 15, 2022
@phargogh
Reducing the indentation level in a nested loop.
a59ffaf 
RE:natcap#1080
phargogh added a commit to phargogh/invest that referenced this issue Sep 15, 2022
@phargogh
Adding a test for the summary statistics table.
6c68518 
RE:natcap#1080
phargogh added a commit to phargogh/invest that referenced this issue Sep 15, 2022
@phargogh
Noting changes in HISTORY. RE:natcap#1080
acc8d5d
@phargogh phargogh mentioned this issue Sep 15, 2022
Merged
3 tasks
phargogh added a commit to phargogh/invest that referenced this issue Oct 21, 2022
@phargogh
Using latest merged version of upstream pygeoprocessing. RE:natcap#1080
70e1d81
phargogh added a commit to phargogh/invest that referenced this issue Oct 21, 2022
@phargogh
Capping qtawesome to avoid recent api change. RE:natcap#1080
59a948e
phargogh added a commit to phargogh/invest that referenced this issue Oct 21, 2022
@phargogh
Fixing pygeoprocessing version hash issue; pointing back to personal …
ba398f0 
…fork RE:natcap#1080
@phargogh phargogh added this to the 3.12.1 milestone Dec 2, 2022
@phargogh phargogh mentioned this issue Dec 2, 2022
Closed
phargogh added a commit to phargogh/invest that referenced this issue Dec 14, 2022
@phargogh
Bumping pygeoprocessing revision. RE:natcap#1080
e180cdb
phargogh added a commit to phargogh/invest that referenced this issue Dec 14, 2022
@phargogh
Removing history notes that had somehow been duplicated. RE:natcap#1080
395a757
phargogh added a commit to phargogh/invest that referenced this issue Dec 14, 2022
@phargogh
Reworking summary table test to clarify intent.
edaa069 
I wasn't being clear about which classification arrays were affecting
which records in the tests.  This commit changes that by renaming a few
array variables, clarifying which values are derived from which arrays,
and adding a helper function to clearly derive values from arrays.

RE:natcap#1080
phargogh added a commit to phargogh/invest that referenced this issue Dec 14, 2022
@phargogh
Renaming variables, adding a comment for clarity.
43a37ec 
RE:natcap#1080
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phargogh phargogh

Labels
bug Something isn't working in progress This issue is actively being worked on
Projects
None yet
Milestone
3.12.1
Development

Successfully merging a pull request may close this issue.

Correct HRA summary statistics table phargogh/invest
1 participant
@phargogh