Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to pandas 2.0.0: remove .xls #1271

Closed
emlys opened this issue Apr 4, 2023 · 0 comments · Fixed by #1272
Closed

Update to pandas 2.0.0: remove .xls #1271

emlys opened this issue Apr 4, 2023 · 0 comments · Fixed by #1272
Assignees
Labels
bug Something isn't working critical for issues likely to obstruct the whole dev team (e.g. broken builds) in progress This issue is actively being worked on

Comments

@emlys
Copy link
Member

emlys commented Apr 4, 2023

pandas 2.0.0 was released yesterday and it's causing one HRA test to break. The error is

for filename, func in [('target.csv', source_df.to_csv),
                       ('target.xls', source_df.to_excel),
                       ('target.xlsx', source_df.to_excel)]:
    full_filepath = os.path.join(self.workspace_dir, filename)
>   func(full_filepath, index=False)
...
ValueError: No engine for filetype: 'xls'

I couldn't find this mentioned in the release notes, but it looks like they removed support for the .xls format (it's been deprecated for a while, and was provided by another library that's no longer maintained). We should accordingly remove the .xls test from HRA - if pandas isn't supporting it, I doubt there's much demand for this outdated format.

Also an opportunity to revisit whether we still want HRA to support excel files, since it's the only model that does so.

@emlys emlys added the bug Something isn't working label Apr 4, 2023
emlys added a commit to emlys/invest that referenced this issue Apr 4, 2023
@emlys emlys self-assigned this Apr 4, 2023
@emlys emlys added the in progress This issue is actively being worked on label Apr 4, 2023
@emlys emlys mentioned this issue Apr 4, 2023
3 tasks
emlys added a commit to emlys/invest that referenced this issue Apr 4, 2023
@emlys emlys added the critical for issues likely to obstruct the whole dev team (e.g. broken builds) label Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working critical for issues likely to obstruct the whole dev team (e.g. broken builds) in progress This issue is actively being worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant