Fix rasterization of spatial criteria relative to InVEST 3.9 #1121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only habitats and stressors should now be rasterized with ALL_TOUCHED=TRUE. Spatial criteria vectors should not be. RE:natcap#1120
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restores a bit of functionality from the InVEST 3.9 HRA implementation that I had missed in the rewrite. In InVEST 3.9, habitat and stressor vectors are rasterized with
ALL_TOUCHED=TRUE, while spatial criteria vectors are rasterized withALL_TOUCHED=FALSE. The HRA rewrite was rasterizing everything asALL_TOUCHED=TRUE, leading to the behavior discussed in https://community.naturalcapitalproject.org/t/habitat-risk-assessment-problems-with-risk-calculation-and-outputs/3122/14.The HRA 3.9 behavior for spatial criteria seems reasonable to me, so I've restored it here and made sure that it's being tested.
No changes in the user's guide are needed for this since we're just restoring existing functionality.
Fixes #1120
Checklist
- [ ] Updated the user's guide (if needed)- [ ] Tested the affected models' UIs (if relevant)