Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for new get_gis_type behavior #1134

Merged
merged 5 commits into from
Dec 14, 2022

Conversation

dcdenu4
Copy link
Member

@dcdenu4 dcdenu4 commented Dec 13, 2022

Description

Pygeoprocessing issue 244 changed how get_gis_type handles non raster and vector types. It will now raise a ValueError in PGP 2.3.5. Updating and in some cases simplifying where this function is used in InVEST (CV, HQ, HRA).

Requirements have been bumped to require PGP 2.3.5 so tests will fail until the release of PGP 2.3.5. natcap/pygeoprocessing#290

Did not update HISTORY since the changes are really not user facing.

Fixes #1133

Checklist

- [ ] Updated HISTORY.rst and link to any relevant issue (if these changes are user-facing)
- [ ] Updated the user's guide (if needed)
- [ ] Tested the affected models' UIs (if relevant)

@dcdenu4 dcdenu4 marked this pull request as ready for review December 13, 2022 21:50
@dcdenu4 dcdenu4 requested a review from phargogh December 13, 2022 21:50
@dcdenu4 dcdenu4 added this to the 3.12.1 milestone Dec 13, 2022
Copy link
Member

@phargogh phargogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@phargogh phargogh merged commit 43d38d4 into natcap:main Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update use of PGP get_gis_type behavior
2 participants