Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt user to extract datastack archive to permanent location #1428

Merged
merged 9 commits into from
Oct 20, 2023

Conversation

emlys
Copy link
Member

@emlys emlys commented Oct 16, 2023

Description

Fixes #1308
Using the Save As dialog to prompt users to choose a location to extract their datastack archive. Now the entire archive is extracted and the file paths loaded into the input form are valid. This does introduce a slight delay while extraction happens, but I didn't think it was bad enough to need a loading indicator.

The dialog looks like this on mac:
image

Checklist

  • Updated HISTORY.rst and link to any relevant issue (if these changes are user-facing)
  • Updated the user's guide (if needed)
  • Tested the Workbench UI (if relevant)

@emlys emlys marked this pull request as ready for review October 17, 2023 19:56
@emlys emlys requested a review from davemfish October 18, 2023 19:07
@emlys emlys self-assigned this Oct 18, 2023
Copy link
Contributor

@davemfish davemfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much @emlys , this looks great to me

@davemfish davemfish merged commit d99d257 into natcap:main Oct 20, 2023
@emlys emlys deleted the bugfix/1308 branch October 3, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_datastack_info from tgz returns an unusable args dictionary
2 participants