Bugfix for gdal ImportErrors observed on Windows #1701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davemfish
changed the title
phargogh
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Makes sense to me, thanks @davemfish ! And also thanks for pulling the old Qt environment variable as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1643
We can use a pyinstaller runtime hook to make sure that the directory containing
gdal.dllis first on thePATHfor Windows users. I tested this out on a local setup where I had previously triggered theImportErrorwith conflicting DLLs from an anaconda path. This seems to do the trick.Checklist