Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: Write a stream extraction function for D8 #272

Closed
phargogh opened this issue Aug 12, 2022 · 0 comments · Fixed by #295
Closed

Proposal: Write a stream extraction function for D8 #272

phargogh opened this issue Aug 12, 2022 · 0 comments · Fixed by #295
Assignees
@phargogh
Labels
enhancement New feature or request in progress Working on it!
Milestone
2.4.0

Comments

@phargogh
Copy link
Member

I recently wrote a script for someone where I had to also write out the raster_calculator op for filtering by a TFA. It's not a hard function to write, but it is something that we do in multiple places in InVEST.

I propose that we roll this in to pygeoprocessing.routing and consolidate the usage of it throughout InVEST. Here are the obvious cases where a TFA filter is used:

NDR, SDR, SWY use MFD and so are using the existing stream extraction function.
@phargogh phargogh self-assigned this Aug 12, 2022
@phargogh phargogh added the enhancement New feature or request label Aug 22, 2022
@phargogh phargogh modified the milestones: 2.3.5, 2.4.0 Dec 2, 2022
@phargogh phargogh added the in progress Working on it! label Dec 20, 2022
phargogh added a commit to phargogh/pygeoprocessing that referenced this issue Dec 20, 2022
@phargogh
Initial stab at d8 stream extraction and a test.
19ce0c1 
RE:natcap#272
phargogh added a commit to phargogh/pygeoprocessing that referenced this issue Dec 20, 2022
@phargogh
Noting change in HISTORY. RE:natcap#272
9d3a3f1
phargogh added a commit to phargogh/pygeoprocessing that referenced this issue Dec 20, 2022
@phargogh
Adding a docstring for the new function.
fec0ddc 
RE:natcap#272
@phargogh phargogh mentioned this issue Dec 20, 2022
Merged
@phargogh phargogh mentioned this issue Jan 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phargogh phargogh

Labels
enhancement New feature or request in progress Working on it!
Projects
None yet
Milestone
2.4.0
Development

Successfully merging a pull request may close this issue.

Add a D8 stream extraction function to pygeoprocessing.routing phargogh/pygeoprocessing
1 participant
@phargogh