Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate rasterization in align_and_resize_raster_stack when masking with a vector #366

Closed
phargogh opened this issue Jan 30, 2024 · 1 comment
Closed

Duplicate rasterization in align_and_resize_raster_stack when masking with a vector #366

phargogh opened this issue Jan 30, 2024 · 1 comment
Assignees
@phargogh
Labels
enhancement New feature or request in progress Working on it!

Comments

@phargogh
Copy link
Member

When using a vector mask in align_and_resize_raster_stack, the vector is rasterized once for each layer that needs to be aligned and masked - and if this is a big vector or a big raster, that can be prohibitively expensive. Runtime is not really an issue for small regions and/or at coarse resolutions, and especially if the vector has very simple geometry.

A preferable solution would be to only rasterize once and then reuse that vector mask once for each warp call.
@phargogh phargogh added the enhancement New feature or request label Jan 30, 2024
@phargogh phargogh self-assigned this Jan 30, 2024
@phargogh phargogh added the in progress Working on it! label Jan 30, 2024
phargogh added a commit to phargogh/pygeoprocessing that referenced this issue Jan 31, 2024
@phargogh
Implementing a fix to remove duplicate rasterization.
fa8ae2c 
RE:natcap#366
phargogh added a commit to phargogh/pygeoprocessing that referenced this issue Jan 31, 2024
@phargogh
Using a different key in the dict instead of string value.
8f126b0 
RE:natcap#366
phargogh added a commit to phargogh/pygeoprocessing that referenced this issue Jan 31, 2024
@phargogh
Testing using an existing mask raster during raster warping.
c4dd76d 
RE:natcap#366
phargogh added a commit to phargogh/pygeoprocessing that referenced this issue Jan 31, 2024
@phargogh
Adding some assertions about the mask raster.
97ce31c 
RE:natcap#366
phargogh added a commit to phargogh/pygeoprocessing that referenced this issue Jan 31, 2024
@phargogh
Fixing a minor string formatting bug. RE:natcap#366
0de5d25
phargogh added a commit to phargogh/pygeoprocessing that referenced this issue Jan 31, 2024
@phargogh
Comments. RE:natcap#366
84d5805
phargogh added a commit to phargogh/pygeoprocessing that referenced this issue Jan 31, 2024
@phargogh
Noting change in HISTORY. RE:natcap#366
b760933
phargogh added a commit to phargogh/pygeoprocessing that referenced this issue Jan 31, 2024
@phargogh
Handling case where mask raster was just created. RE:natcap#366
ef70242
phargogh added a commit to phargogh/pygeoprocessing that referenced this issue Feb 1, 2024
@phargogh
Adding another note about the ability to have align_and_resize_raster…
1e5f89f 
…_stack's mask persist. RE:natcap#366
phargogh added a commit to phargogh/pygeoprocessing that referenced this issue Feb 6, 2024
@phargogh
Improving a comment in warp_raster. RE:natcap#366
e5c8557
phargogh added a commit to phargogh/pygeoprocessing that referenced this issue Feb 6, 2024
@phargogh
Using mask_options instead, raising deprecationwarning.
c55e469 
RE:natcap#366
@phargogh
Copy link
Member Author

phargogh commented Feb 6, 2024

Resolved in #367

@phargogh phargogh closed this as completed Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phargogh phargogh

Labels
enhancement New feature or request in progress Working on it!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@phargogh