Update control keys so that ctrl-p goes up #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expected behavior of ctrl-p is to move up a line but instead it was moving down. I frequently use emacs shortcuts for moving up and down lines and I noticed this. Made a single change so that it works as expected now.
|
Oh wow that's a mistake in my recent rewrite for sure. Thanks for catching this! I'll try to get this released in a 10.0.1 soon |
|
Just released 0.10.1, thanks again for the bugfix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected behavior of ctrl-p is to move up a line of output but instead it was moving down.
I frequently use emacs shortcuts for moving up and down lines and I noticed this. Made a single change so that it works as expected now.