Stop code signing binaries and packages

natemcmaster · Jun 28, 2020 · 3c9dcee · 3c9dcee
1 parent 59781ae
commit 3c9dcee
Show file tree

Hide file tree

Showing 6 changed files with 1 addition and 87 deletions.
diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
@@ -2,23 +2,11 @@
   "version": 1,
   "isRoot": true,
   "tools": {
-    "azuresigntool": {
-      "version": "2.0.17",
-      "commands": [
-        "azuresigntool"
-      ]
-    },
-    "nugetkeyvaultsigntool": {
-      "version": "1.2.28",
-      "commands": [
-        "NuGetKeyVaultSignTool"
-      ]
-    },
     "dotnet-reportgenerator-globaltool": {
       "version": "4.4.0",
       "commands": [
         "reportgenerator"
       ]
     }
   }
-}
+}
diff --git a/Directory.Build.props b/Directory.Build.props
@@ -34,10 +34,6 @@
     <Nullable>annotations</Nullable>
     <AssemblyOriginatorKeyFile>$(MSBuildThisFileDirectory)src\StrongName.snk</AssemblyOriginatorKeyFile>
     <SignAssembly>true</SignAssembly>
-    <AzureKeyVaultUrl>https://nmcmaster.vault.azure.net</AzureKeyVaultUrl>
-    <AzureKeyVaultClientId>6a27a2da-bb78-4baa-bd2b-150fe89ea039</AzureKeyVaultClientId>
-    <AzureKeyVaultClientSecret>$(KEYVAULT_CLIENT_SECRET)</AzureKeyVaultClientSecret>
-    <CodeSignCertName>DigiCertCodeSign</CodeSignCertName>
 
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <GenerateFullPaths Condition="'$(TERM_PROGRAM)' == 'vscode'">true</GenerateFullPaths>

diff --git a/azure-pipelines.yml b/azure-pipelines.yml
@@ -10,7 +10,6 @@ pr:
 - '*'
 
 variables:
-- group: AzureKeyVault
 - name: BUILD_NUMBER
   value: $[counter('buildnumber', 1)]
 
@@ -39,8 +38,6 @@ jobs:
       packageType: runtime
   - powershell: ./build.ps1 -ci
     displayName: Invoke build.ps1
-    env:
-      KEYVAULT_CLIENT_SECRET: $(kv-access-token)
   - task: PublishTestResults@2
     displayName: Publish test results
     condition: always()

diff --git a/build.ps1 b/build.ps1
@@ -5,8 +5,6 @@ param(
     $Configuration = $null,
     [switch]
     $ci,
-    [switch]
-    $sign,
     [Parameter(ValueFromRemainingArguments = $true)]
     [string[]]$MSBuildArgs
 )
@@ -39,12 +37,6 @@ if (-not (Test-Path variable:\IsCoreCLR)) {
     $IsWindows = $true
 }
 
-$CodeSign = $sign -or ($ci -and -not $isPr -and $IsWindows)
-
-if ($CodeSign) {
-    $MSBuildArgs += '-p:CodeSign=true'
-}
-
 $artifacts = "$PSScriptRoot/artifacts/"
 
 Remove-Item -Recurse $artifacts -ErrorAction Ignore

diff --git a/src/CodeSign.targets b/src/CodeSign.targets
diff --git a/src/Directory.Build.targets b/src/Directory.Build.targets
@@ -14,6 +14,4 @@
     <Message Importance="High" Text="##vso[build.updatebuildnumber]$(PackageVersion)" />
   </Target>
 
-  <Import Project="CodeSign.targets" />
-
 </Project>