cleanup: further code deduplication on new hosting APIs (#416)

natemcmaster · Jan 9, 2021 · f5938c8 · f5938c8
1 parent 643f9c3
commit f5938c8
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 58 deletions.
diff --git a/src/Hosting.CommandLine/HostBuilderExtensions.cs b/src/Hosting.CommandLine/HostBuilderExtensions.cs
@@ -35,7 +35,7 @@ public static async Task<int> RunCommandLineApplicationAsync<TApp>(
             CancellationToken cancellationToken = default)
             where TApp : class
         {
-            return await RunCommandLineApplicationAsync<TApp>(hostBuilder, args, app => { }, cancellationToken);
+            return await RunCommandLineApplicationAsync<TApp>(hostBuilder, args, null, cancellationToken);
         }
 
         /// <summary>
@@ -56,18 +56,7 @@ public static async Task<int> RunCommandLineApplicationAsync<TApp>(
             CancellationToken cancellationToken = default)
             where TApp : class
         {
-            var state = new CommandLineState(args);
-            hostBuilder.Properties[typeof(CommandLineState)] = state;
-            hostBuilder.ConfigureServices(
-                (context, services)
-                    =>
-                {
-                    services.AddCommonServices(state);
-                    services.AddSingleton<ICommandLineService, CommandLineService<TApp>>();
-                    services.AddSingleton(configure);
-                });
-
-            using var host = hostBuilder.Build();
+            using var host = hostBuilder.UseCommandLineApplication<TApp>(args, configure).Build();
             return await host.RunCommandLineApplicationAsync(cancellationToken);
         }
 
@@ -88,16 +77,14 @@ public static async Task<int> RunCommandLineApplicationAsync(
             Action<CommandLineApplication> configure,
             CancellationToken cancellationToken = default)
         {
+            configure ??= _ => { };
             var state = new CommandLineState(args);
             hostBuilder.Properties[typeof(CommandLineState)] = state;
-            hostBuilder.ConfigureServices(
-                (context, services)
-                    =>
-                {
-                    services.AddCommonServices(state);
-                    services.AddSingleton<ICommandLineService, CommandLineService>();
-                    services.AddSingleton(configure);
-                });
+            hostBuilder.ConfigureServices((context, services) =>
+                services
+                    .AddCommonServices(state)
+                    .AddSingleton<ICommandLineService, CommandLineService>()
+                    .AddSingleton(configure));
 
             using var host = hostBuilder.Build();
             return await host.RunCommandLineApplicationAsync(cancellationToken);
@@ -131,50 +118,32 @@ public static IHostBuilder UseCommandLineApplication<TApp>(
             Action<CommandLineApplication<TApp>> configure)
             where TApp : class
         {
-            configure ??= app => { };
+            configure ??= _ => { };
             var state = new CommandLineState(args);
             hostBuilder.Properties[typeof(CommandLineState)] = state;
-            hostBuilder.ConfigureServices(
-                (context, services) =>
-                {
-                    services
-                        .TryAddSingleton<StoreExceptionHandler>();
-                    services
-                        .TryAddSingleton<IUnhandledExceptionHandler>(provider => provider.GetRequiredService<StoreExceptionHandler>());
-                    services
-                        .AddSingleton<IHostLifetime, CommandLineLifetime>()
-                        .TryAddSingleton(PhysicalConsole.Singleton);
-                    services
-                        .AddSingleton(provider =>
-                        {
-                            state.SetConsole(provider.GetService<IConsole>());
-                            return state;
-                        })
-                        .AddSingleton<CommandLineContext>(state)
-                        .AddSingleton<ICommandLineService, CommandLineService<TApp>>();
-                    services
-                        .AddSingleton(configure);
-                });
+            hostBuilder.ConfigureServices((context, services) =>
+                services
+                    .AddCommonServices(state)
+                    .AddSingleton<ICommandLineService, CommandLineService<TApp>>()
+                    .AddSingleton(configure));
 
             return hostBuilder;
         }
 
-        private static void AddCommonServices(this IServiceCollection services, CommandLineState state)
+        private static IServiceCollection AddCommonServices(this IServiceCollection services, CommandLineState state)
         {
-            services
-                .TryAddSingleton<StoreExceptionHandler>();
-            services
-                .TryAddSingleton<IUnhandledExceptionHandler>(provider => provider.GetRequiredService<StoreExceptionHandler>());
+            services.TryAddSingleton<StoreExceptionHandler>();
+            services.TryAddSingleton<IUnhandledExceptionHandler>(provider => provider.GetRequiredService<StoreExceptionHandler>());
+            services.TryAddSingleton(PhysicalConsole.Singleton);
             services
                 .AddSingleton<IHostLifetime, CommandLineLifetime>()
-                .TryAddSingleton(PhysicalConsole.Singleton);
-            services
                 .AddSingleton(provider =>
                 {
                     state.SetConsole(provider.GetService<IConsole>());
                     return state;
                 })
                 .AddSingleton<CommandLineContext>(state);
+            return services;
         }
     }
 }
diff --git a/src/Hosting.CommandLine/HostExtensions.cs b/src/Hosting.CommandLine/HostExtensions.cs
@@ -1,16 +1,16 @@
 // Copyright (c) Nate McMaster.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
+using System;
+using System.Runtime.ExceptionServices;
+using System.Threading;
+using System.Threading.Tasks;
+using McMaster.Extensions.CommandLineUtils;
+using McMaster.Extensions.Hosting.CommandLine.Internal;
+using Microsoft.Extensions.DependencyInjection;
+
 namespace Microsoft.Extensions.Hosting
 {
-    using System;
-    using System.Runtime.ExceptionServices;
-    using System.Threading;
-    using System.Threading.Tasks;
-    using McMaster.Extensions.CommandLineUtils;
-    using McMaster.Extensions.Hosting.CommandLine.Internal;
-    using Microsoft.Extensions.DependencyInjection;
-
     /// <summary>
     /// Extension methods for <see cref="IHost" /> support.
     /// </summary>