Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 303: Fixed usage help to display [command] first then [options]. #308

Merged
merged 2 commits into from
Nov 22, 2019

Conversation

AndreGleichner
Copy link
Contributor

Should be:
Usage: mytool [command] [options]
instead of:
Usage: mytool [options] [command]

Having any options in front of the command verb fails, so the usage help should reflect this.

I'm glad you're about to open a PR. Just a few tips before you click submit:

  • Feel free to add a note to the CHANGELOG.md file and/or the releasenotes.props file. I'd like to give you credit for your work.
  • Please make sure you read, or at least skimmed, CONTRIBUTING.md
  • I may not take PRs if they come out of the blue and make big changes.
    If you're not sure if something is a "big change", please open an issue first.

Thanks!

Should be:
  Usage: mytool [command] [options]
instead of:
  Usage: mytool [options] [command]

Having any options in front of the command verb fails, so the usage help should reflect this.
@natemcmaster
Copy link
Owner

Thanks for the pull request! I'm happy to have a new contributor.

Before I merge, can I trouble you to fix the failing tests? They should be updated to reflect the new behavior. See https://dev.azure.com/natemcmaster/github/_build/results?buildId=604&view=ms.vss-test-web.build-test-results-tab for a list of the test failures. You can check if they will pass locally by executing ./build.ps1 from the PowerShell command line.

@AndreGleichner
Copy link
Contributor Author

Happy to help ;)

@natemcmaster natemcmaster merged commit e93a7fc into natemcmaster:master Nov 22, 2019
@natemcmaster
Copy link
Owner

Thanks! I'll add you to the release notes

@natemcmaster natemcmaster mentioned this pull request Dec 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants