Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't mask OperationCanceledException triggered by SIGINT #483

Merged
merged 2 commits into from
Dec 26, 2021

Conversation

natemcmaster
Copy link
Owner

Fixes #459

@codecov
Copy link

codecov bot commented Dec 26, 2021

Codecov Report

Merging #483 (04de66e) into main (6783c5f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #483   +/-   ##
=======================================
  Coverage   82.19%   82.19%           
=======================================
  Files         106      106           
  Lines        3286     3286           
=======================================
  Hits         2701     2701           
  Misses        585      585           
Impacted Files Coverage Δ
src/CommandLineUtils/CommandLineApplication.cs 93.58% <ø> (-0.04%) ⬇️
...CommandLineUtils/CommandLineApplication.Execute.cs 70.58% <100.00%> (+1.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6783c5f...04de66e. Read the comment docs.

@natemcmaster natemcmaster marked this pull request as ready for review December 26, 2021 23:48
@natemcmaster natemcmaster added this to the 4.0.0 milestone Dec 26, 2021
@natemcmaster natemcmaster changed the title Lift handling of OperationCanceledException to the static helper methods on CommandLineApplication fix: don't mask OperationCanceledException triggered by SIGINT Dec 26, 2021
@natemcmaster natemcmaster merged commit 3774688 into main Dec 26, 2021
@natemcmaster natemcmaster deleted the cancel branch December 26, 2021 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OperationCanceledException in ExecuteAsync is always masked as caused by SIGINT
1 participant