Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1] feat: update service to use latest @iconify/json and tooling #104

Closed
wants to merge 2 commits into from

Conversation

stramel
Copy link
Collaborator

@stramel stramel commented May 25, 2023

This PR brings the service up-to-date with the Iconify ecosystem.

  • Removes the deprecated @iconify/json-tools
  • Updates the @iconify/json package to v2 which should be non-breaking

This would close a lot of bugs for the existing v0 codebase. Including #29

NOTE: this untested currently

@changeset-bot
Copy link

changeset-bot bot commented May 25, 2023

⚠️ No Changeset found

Latest commit: c77c520

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@stramel stramel requested a review from natemoo-re May 25, 2023 16:20
@stramel stramel self-assigned this May 25, 2023
@vercel
Copy link

vercel bot commented May 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-astroicon ❌ Failed (Inspect) May 25, 2023 4:34pm
astroicon ❌ Failed (Inspect) May 25, 2023 4:34pm

@stramel stramel force-pushed the ms/update-service branch from d60f2c5 to c77c520 Compare May 25, 2023 16:34
@stramel stramel changed the title feat: update service to use latest @iconify/json and tooling [v1] feat: update service to use latest @iconify/json and tooling May 25, 2023
@natemoo-re
Copy link
Owner

Going to close this since I'm planning on freezing the service as it is. v1 will rely on locally installed icon packs!

@natemoo-re natemoo-re closed this Jun 6, 2023
@stramel stramel deleted the ms/update-service branch June 6, 2023 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants