Update Reference Hardware Specs (paritytech#13317)

* Remove Polkadot Wiki Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Update requirements for new ref hardware Signed-off-by: Oliver Tale-Yazdi <[email protected]> * Add test Signed-off-by: Oliver Tale-Yazdi <[email protected]> --------- Signed-off-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: parity-processbot <>
nathanwhit · Jul 19, 2023 · 56eb32f · 56eb32f
1 parent 24c8b84
commit 56eb32f
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 9 deletions.
diff --git a/utils/frame/benchmarking-cli/src/machine/hardware.rs b/utils/frame/benchmarking-cli/src/machine/hardware.rs
@@ -25,9 +25,6 @@ lazy_static! {
 	///
 	/// These values are provided by Parity, however it is possible
 	/// to use your own requirements if you are running a custom chain.
-	///
-	/// The reference hardware is describe here:
-	/// <https://wiki.polkadot.network/docs/maintain-guides-how-to-validate-polkadot>
 	pub static ref SUBSTRATE_REFERENCE_HARDWARE: Requirements = {
 		let raw = include_bytes!("reference_hardware.json").as_slice();
 		serde_json::from_slice(raw).expect("Hardcoded data is known good; qed")
@@ -37,13 +34,35 @@ lazy_static! {
 #[cfg(test)]
 mod tests {
 	use super::*;
+	use sc_sysinfo::{Metric, Requirement, Requirements, Throughput};
 
-	/// `SUBSTRATE_REFERENCE_HARDWARE` can be en- and decoded.
+	/// `SUBSTRATE_REFERENCE_HARDWARE` can be decoded.
 	#[test]
 	fn json_static_data() {
 		let raw = serde_json::to_string(&*SUBSTRATE_REFERENCE_HARDWARE).unwrap();
 		let decoded: Requirements = serde_json::from_str(&raw).unwrap();
 
 		assert_eq!(decoded, SUBSTRATE_REFERENCE_HARDWARE.clone());
 	}
+
+	/// The hard-coded values are correct.
+	#[test]
+	fn json_static_data_is_correct() {
+		assert_eq!(
+			*SUBSTRATE_REFERENCE_HARDWARE,
+			Requirements(vec![
+				Requirement { metric: Metric::Blake2256, minimum: Throughput::from_mibs(783.27) },
+				Requirement {
+					metric: Metric::Sr25519Verify,
+					minimum: Throughput::from_kibs(560.670000128),
+				},
+				Requirement {
+					metric: Metric::MemCopy,
+					minimum: Throughput::from_gibs(11.4925205078125003),
+				},
+				Requirement { metric: Metric::DiskSeqWrite, minimum: Throughput::from_mibs(950.0) },
+				Requirement { metric: Metric::DiskRndWrite, minimum: Throughput::from_mibs(420.0) },
+			])
+		);
+	}
 }
diff --git a/utils/frame/benchmarking-cli/src/machine/reference_hardware.json b/utils/frame/benchmarking-cli/src/machine/reference_hardware.json
@@ -1,22 +1,22 @@
 [
 	{
 		"metric": "Blake2256",
-		"minimum": 1029.0
+		"minimum": 783.27
 	},
 	{
 		"metric": "Sr25519Verify",
-		"minimum": 0.650391
+		"minimum": 0.547529297
 	},
 	{
 		"metric": "MemCopy",
-		"minimum": 14666.752
+		"minimum": 11768.341
 	},
 	{
 		"metric": "DiskSeqWrite",
-		"minimum": 450.0
+		"minimum": 950.0
 	},
 	{
 		"metric": "DiskRndWrite",
-		"minimum": 200.0
+		"minimum": 420.0
 	}
 ]