Cleanup #63
Merged
Cleanup #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y to download restricted references without proper authentication/permissions.
RobLBaker
added
documentation
wright13
reviewed
Dec 23, 2024
| @@ -138,7 +138,7 @@ get_refs_info <- function (reference_type = "dataPackage", | |||
| #' | |||
| #' If a data package fails to download (or load) into R, the function will return NAs instead of summary data about the data package as well as a message about the package status ("Loads", "Error") in the dataframe that the function returns. The function will ignore files that fall outside the data package specifications (one or more .csv files and a single .xml file ending in *_metadata.xml). | |||
| #' | |||
| #' When `check_metadata` is set to the default `FALSE`, the function will attempt to and load any .csv, regardless of the contents. Data packages with restricted access can produce false positives if you do not have the appropriate permissions to download the data as the function will still download the files, but they will be populated with unhelpful hmtl rather than the intended data. Functions that fail to load into R likely violate the data package specifications in some fundamental way (e.g. .CSV file instead of .csv or no .csv files at all). | |||
There was a problem hiding this comment.
In the future, might be worth throwing an error when it downloads a csv with an html error instead of the actual data.
There was a problem hiding this comment.
Totally, if that behavior persists on the DataStore side. It was rather unexpected and Judd said we should probably improve how DataStore handles the situation. I'm holding off until that gets figured out in the hopes that it does so relatively soon.
wright13
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get rid of old/bad functions and their files, add importFrom to some functions that needed it, remove unused packages from Imports, add variables to the globalVariable list, and fix up some documentation. Result: 0 warnings 0 errors 0 notes!