Improve stream sourcing consumers stall handling #5366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jnmoyne
commented
Apr 29, 2024
jnmoyne
commented
- Resets the stalling detection timestamp upon re-creating the consumer
- Adjust the idle heart beat for source/mirror consumers from 1s to 5s
- Reset the stall detection timestamp when re-creating a new consumer to avoid the consumer then being detected stale after just 1 HB period (rather than 3). - retryMirrorConsumer should call cancelMirrorConsumer to clean up any existing consumer before re-creating a new consumer. - Adjust `sourceHealthCheckInterval` from 1 to 20 seconds, which does not trigger any stalling detections anymore for the SourcingMany test. Signed-off-by: Jean-Noël Moyne <[email protected]>
Signed-off-by: Jean-Noël Moyne <[email protected]>
Signed-off-by: Jean-Noël Moyne <[email protected]>
Adjust the check at the end of `TestJetStreamClusterMirrorAndSourceExpiration` to 40s (as it has to be slightly more than 3 HB interval) Signed-off-by: Jean-Noël Moyne <[email protected]>
Signed-off-by: Jean-Noël Moyne <[email protected]>
Signed-off-by: Jean-Noël Moyne <[email protected]>
wallyqs
pushed a commit
that referenced
this pull request
May 1, 2024
- Resets the stalling detection timestamp upon re-creating the consumer - Adjust the idle heart beat for source/mirror consumers from 1s to 5s --------- Signed-off-by: Jean-Noël Moyne <[email protected]>
wallyqs
pushed a commit
that referenced
this pull request
May 1, 2024
- Resets the stalling detection timestamp upon re-creating the consumer - Adjust the idle heart beat for source/mirror consumers from 1s to 5s --------- Signed-off-by: Jean-Noël Moyne <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.