-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import new Base images from media library #1
Labels
enhancement
New feature or request
Milestone
Comments
josecelano
added a commit
that referenced
this issue
Oct 18, 2021
josecelano
added a commit
that referenced
this issue
Oct 18, 2021
josecelano
added a commit
that referenced
this issue
Oct 18, 2021
josecelano
added a commit
that referenced
this issue
Oct 18, 2021
josecelano
added a commit
that referenced
this issue
Oct 18, 2021
josecelano
added a commit
that referenced
this issue
Oct 18, 2021
This was referenced Oct 18, 2021
josecelano
added a commit
that referenced
this issue
Oct 18, 2021
josecelano
added a commit
that referenced
this issue
Oct 18, 2021
josecelano
added a commit
that referenced
this issue
Oct 18, 2021
josecelano
added a commit
that referenced
this issue
Oct 18, 2021
josecelano
added a commit
that referenced
this issue
Oct 18, 2021
josecelano
added a commit
that referenced
this issue
Oct 18, 2021
josecelano
added a commit
that referenced
this issue
Oct 18, 2021
josecelano
added a commit
that referenced
this issue
Oct 18, 2021
josecelano
added a commit
that referenced
this issue
Oct 18, 2021
josecelano
added a commit
that referenced
this issue
Oct 18, 2021
josecelano
added a commit
that referenced
this issue
Oct 18, 2021
I'm using git submodules and it seems to work fine in this case but I do not have a list of prons and cons yet versus using subtrees. |
josecelano
added a commit
that referenced
this issue
Oct 19, 2021
josecelano
added a commit
that referenced
this issue
Oct 19, 2021
josecelano
added a commit
that referenced
this issue
Oct 19, 2021
josecelano
added a commit
that referenced
this issue
Oct 29, 2021
josecelano
added a commit
that referenced
this issue
Jun 13, 2022
josecelano
added a commit
that referenced
this issue
Jun 13, 2022
josecelano
added a commit
that referenced
this issue
Jun 13, 2022
josecelano
added a commit
that referenced
this issue
Jun 13, 2022
…le from GitHub API using dir info
josecelano
added a commit
that referenced
this issue
Jun 13, 2022
josecelano
added a commit
that referenced
this issue
Jun 13, 2022
josecelano
added a commit
that referenced
this issue
Jun 13, 2022
josecelano
added a commit
that referenced
this issue
Jun 13, 2022
josecelano
added a commit
that referenced
this issue
Jun 13, 2022
josecelano
added a commit
that referenced
this issue
Jun 13, 2022
josecelano
added a commit
that referenced
this issue
Jun 13, 2022
josecelano
added a commit
that referenced
this issue
Jun 13, 2022
josecelano
added a commit
that referenced
this issue
Jun 13, 2022
josecelano
added a commit
that referenced
this issue
Jun 13, 2022
josecelano
added a commit
that referenced
this issue
Jun 13, 2022
josecelano
added a commit
that referenced
this issue
Jun 13, 2022
josecelano
added a commit
that referenced
this issue
Jun 13, 2022
josecelano
added a commit
that referenced
this issue
Jun 13, 2022
josecelano
added a commit
that referenced
this issue
Jun 13, 2022
josecelano
added a commit
that referenced
this issue
Jun 13, 2022
josecelano
added a commit
that referenced
this issue
Jun 13, 2022
josecelano
added a commit
that referenced
this issue
Jun 13, 2022
josecelano
added a commit
that referenced
this issue
Jun 13, 2022
josecelano
added a commit
that referenced
this issue
Jun 13, 2022
josecelano
added a commit
that referenced
this issue
Jun 13, 2022
josecelano
added a commit
that referenced
this issue
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now the current workflow only uses the images that are already inside the data folder.
The
data
folder containstif
images that were manually copied to this repo using[dvc](https://dvc.org/)
We got the images from this media library: https://github.com/Nautilus-Cyberneering/chinese-ideographs
You can deploy the application using the script:
npm run deploy
. That command executes the script./scripts/copy-images.sh
which copies the images from thedata
folder to thepublic\images
folder.Those are the images that are shown on the website: https://nautilus-cyberneering.github.io/chinese-ideographs-website/
We want to update the website when new images are added to the source library. For this first iteration we are going to use this solution:
deploy.yml
andimport-base-images.yml
import-base-images.yml
) is going to git clone the library and auto-commit new Base images inpublic/images/
folder.deploy.yml
) will be modified to only build and deploy the website usinggh-pages
.The
deploy
workflow will:checkout
the website repogh-pages
And the
import-base-images.yml
workflow will:checkout
the library repo in a subfolder (gitignored). It will be the currentdata
folder, but maybe something like:library\data\...
dvc pull
all images in the sub git project (we are not going to use git submodules or git subtrees for the time being, although maybe it worths considering it).public\images
)deploy.yml
workflow to publish the new version of the website ongh-pages
. If this step is complicated for the POC we can simply repeat the steps needed to publish the website on this workflow.The reasons to have two workflows are:
import
workflow. We want to trigger it from the library repo and we want to pass it an event payload, which does not make sense for the standard deploy.Future improvements:
import-base-images.yml
workflow on-demand only when Base images change in the library repo. We could trigger a workflow on the website repo from the library repo using GitHub API: https://github.com/marketplace/actions/repository-dispatchThe text was updated successfully, but these errors were encountered: