Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail when GPG was installed with non-english languages #66

Closed
yeraydavidrodriguez opened this issue Feb 23, 2022 · 0 comments · Fixed by #68
Closed

Tests fail when GPG was installed with non-english languages #66

yeraydavidrodriguez opened this issue Feb 23, 2022 · 0 comments · Fixed by #68
Assignees
Labels
bug Something isn't working

Comments

@yeraydavidrodriguez
Copy link
Collaborator

There are two tests that may fail if the user has installed the GPG suite using a non-english language: "should allow to sign commits" and "should allow to overwrite commit signing key"

This occurs because of the way the test checks for correctness. In both cases, we expect to find this string in an output structure:

gpg: using RSA key ${signingKeyFingerprint}

However, this is generated by GPG, and depends on the language with which was installed. For instance, in spanish, this string would be:

gpg: usando RSA clave ${signingKeyFingerprint}

And the test would fail, as in other languages. At the moment of writing this, the checks are made on queue.tests.ts:195 and main.test.ts:224.

To fix this, we need to perform a language-independent comparison, maybe checking the existence of the words "gpg", "RSA" and the fingerprint in the same string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant