Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests to make them compatible with non-english GPG installations #68

Merged
merged 1 commit into from
Feb 23, 2022

Conversation

yeraydavidrodriguez
Copy link
Collaborator

This will make the tests referenced in #66 compatible with non-english GPG installations.

To do so, it replaces the full expected string with a RegExp in which the words "gpg:", RSA and the fingerprint are checked.

Although we cannot assure that it creates false-positive tests (maybe considering valid a string reporting an error with the RSA key), I think it is very unlikely, but the possibility of the user having a non-english GPG installation is very high.

@yeraydavidrodriguez yeraydavidrodriguez added the bug Something isn't working label Feb 23, 2022
@yeraydavidrodriguez yeraydavidrodriguez linked an issue Feb 23, 2022 that may be closed by this pull request
@github-actions
Copy link

MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 4 0 0.14s
✅ COPYPASTE jscpd yes no 1.36s
✅ CREDENTIALS secretlint yes no 0.78s
✅ GIT git_diff yes no 0.01s
✅ JAVASCRIPT standard 1 0 0 1.12s
✅ JSON eslint-plugin-jsonc 7 0 0 0.77s
✅ JSON jsonlint 7 0 1.55s
✅ JSON prettier 7 1 0 1.06s
✅ JSON v8r 7 0 5.97s
⚠️ MARKDOWN markdownlint 2 0 1 0.31s
✅ MARKDOWN markdown-link-check 2 0 4.96s
✅ MARKDOWN markdown-table-formatter 2 2 0 0.23s
✅ SPELL cspell 80 0 2.84s
✅ SPELL misspell 80 2 0 0.13s
✅ TYPESCRIPT eslint 54 2 0 12.35s
✅ YAML prettier 7 0 0 1.79s
✅ YAML v8r 7 0 7.34s
✅ YAML yamllint 7 0 0.25s

See errors details in artifact MegaLinter reports on CI Job page

@josecelano josecelano merged commit 968d428 into main Feb 23, 2022
@yeraydavidrodriguez yeraydavidrodriguez deleted the issue-66-fix-tests branch March 4, 2022 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests fail when GPG was installed with non-english languages
2 participants