Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prep v1.5.0 #550

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Prep v1.5.0 #550

merged 2 commits into from
Aug 28, 2023

Conversation

itdependsnetworks
Copy link
Contributor

No description provided.

@itdependsnetworks itdependsnetworks changed the base branch from develop to next August 26, 2023 03:32
@itdependsnetworks itdependsnetworks marked this pull request as draft August 26, 2023 03:32
@itdependsnetworks
Copy link
Contributor Author

itdependsnetworks commented Aug 26, 2023 •
edited
Loading

Still need to

  • release 1.4.2
  • merge next into develop
  • bump version to 1.5.0 in pyproject.toml
  • release 1.5.0

@itdependsnetworks itdependsnetworks force-pushed the prep-v1.5.0 branch 4 times, most recently from 1959c33 to d88fe0c Compare August 26, 2023 21:19
@itdependsnetworks itdependsnetworks marked this pull request as ready for review August 26, 2023 21:19
@itdependsnetworks itdependsnetworks force-pushed the prep-v1.5.0 branch 3 times, most recently from 62287c6 to 532d32b Compare August 28, 2023 13:58
jeffkala
jeffkala approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@jeffkala jeffkala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question on black version, and update to release notes. But overall approved.

docs/admin/release_notes/version_1.5.md Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
jeffkala
jeffkala approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@jeffkala jeffkala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@itdependsnetworks itdependsnetworks merged commit 3231fae into nautobot:next Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffkala jeffkala jeffkala approved these changes

@nkallergis nkallergis Awaiting requested review from nkallergis nkallergis is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itdependsnetworks @jeffkala