implement plan_result and deploy_result #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffkala
requested review from
itdependsnetworks and
nkallergis
as code owners
joewesch
reviewed
Sep 15, 2023
Co-authored-by: Joe Wesch <[email protected]>
joewesch
reviewed
Sep 15, 2023
nautobot_golden_config/forms.py
Outdated
| ) | ||
| deploy_result_id = utilities_forms.DynamicModelMultipleChoiceField( | ||
| queryset=JobResult.objects.all(), | ||
| query_params={"nautobot_golden_config_config_plan_null": True}, |
There was a problem hiding this comment.
Suggested change
| query_params={"nautobot_golden_config_config_plan_null": True}, | |
| query_params={"nautobot_golden_config_config_plan_deploy_result_null": True}, |
I think this needs to be the related name? Double check me on this.
joewesch
reviewed
Sep 15, 2023
| @@ -108,7 +108,7 @@ | |||
| } | |||
|
|
|||
| var jobClass = "plugins/nautobot_golden_config.jobs/GenerateConfigPlans"; | |||
| var redirectUrlTemplate = "/plugins/golden-config/config-plan/?job_result_id={jobData.result.id}"; | |||
| var redirectUrlTemplate = "/plugins/golden-config/config-plan/?play_result_id={jobData.result.id}"; | |||
There was a problem hiding this comment.
Suggested change
| var redirectUrlTemplate = "/plugins/golden-config/config-plan/?play_result_id={jobData.result.id}"; | |
| var redirectUrlTemplate = "/plugins/golden-config/config-plan/?plan_result_id={jobData.result.id}"; |
joewesch
reviewed
Sep 15, 2023
nautobot_golden_config/templates/nautobot_golden_config/configplan_retrieve.html
Show resolved
Hide resolved
…ugin-golden-config into jkala-deploy-result
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.