-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add useAcceleration option to PanInput #205
Open
malangfox
wants to merge
16
commits into
naver:master
Choose a base branch
from
malangfox:feat-animate-release
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daybrush
reviewed
Oct 13, 2022
@@ -10,7 +10,7 @@ | |||
{ | |||
"basePath": "packages/axes/dist", | |||
"dists": [ | |||
"demo/dist" | |||
"packages/demo/dist" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will manage dist by version like cdn.
Check the latest and version folders.
malangfox
changed the title
feat: add animateOn option
feat: add useAcceleration option to PanInput
Dec 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
animateOn
option adds a new way to triggerchange
events by continuous animation.Usage
This is an example of applying
animateOn
option.How it works
Legacy behavior
animateOn: "release"
triggerschange
event directly to the destination from the input.Newly added behavior
animateOn: "change"
will play the animation with the destination from the input.animateOn: "change"
uses the newchangeTo
method in AnimationManager.changeTo
calls_animateLoop
that starts the animation set by the user and fires continuous change events.Movement through the
changeTo
method does not triggeranimationStart
andanimationEnd
events.When the input is released, the existing animation behavior works for both options triggering
animationStart
andanimationEnd
events, and the sequence of events does not change.