Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Fallback på font-family i body #1647

Merged
merged 3 commits into from
Oct 10, 2022
Merged

[FIX] Fallback på font-family i body #1647

merged 3 commits into from
Oct 10, 2022

Conversation

macbruker
Copy link
Contributor

Denne PRen løser flere problemer med feil font på nav.no. Dekoratøren drar inn CSSen fra designsystemet. Der scopes «alt» utenom body til .decorator-wrapper, som gjør at følgende linjer kan skape trøbbel enkelte steder. Se skjermbilde under.

body {
    font-family: var(--navds-font-family)
}

Fremfor å be alle apper om å hente inn designsystemet, foreslår jeg derfor å flytte font-family fra body til :root.

image

@macbruker macbruker requested a review from KenAJoh October 6, 2022 10:03
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2022

Chromatic build-output:

commit: 97f541fcb

@macbruker macbruker self-assigned this Oct 6, 2022
KenAJoh
KenAJoh previously approved these changes Oct 10, 2022
@KenAJoh KenAJoh changed the title Flytte font-family fra body til :root [FIX] Fallback på font-family i body Oct 10, 2022
@KenAJoh KenAJoh merged commit 225e882 into master Oct 10, 2022
@KenAJoh KenAJoh deleted the move-font-family branch October 10, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants