Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mouse movements should "take over" from keyboard focus in Combobox dropdown list, and vice versa, acting like a native select. #2193

Conversation

it-vegard
Copy link
Contributor

Description

Move movements "take over" from keyboard focus in Combobox dropdown list, and vice versa, acting like a native select.

Fixes #2165

Change summary

  • When moving the mouse over a list item, the virtual keyboard focus is also moved to that item.
  • If hovering over an item, but moving focus with the arrow keys, the hover styling disappears.

@changeset-bot
Copy link

changeset-bot bot commented Aug 18, 2023

🦋 Changeset detected

Latest commit: af2deeb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@navikt/ds-react Patch
@navikt/ds-css Patch
@navikt/aksel-stylelint Patch
@navikt/aksel Patch
@navikt/ds-tokens Patch
@navikt/ds-tailwind Patch
@navikt/aksel-icons Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@it-vegard
Copy link
Contributor Author

Should add some tests on Monday, as well as a changelog item.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 18, 2023

Storybook demo

Endringer til review: 0

45efce057 | 49 komponenter | 322 stories

@it-vegard it-vegard changed the title Move movements should "take over" from keyboard focus in Combobox dropdown list, and vice versa, acting like a native select. Mouse movements should "take over" from keyboard focus in Combobox dropdown list, and vice versa, acting like a native select. Aug 21, 2023
@it-vegard it-vegard force-pushed the bugfix/should-not-have-simultaneous-hover-and-focused-option-in-combobox branch from 66d065d to 54d13f3 Compare August 23, 2023 10:03
@it-vegard it-vegard merged commit a8ad03d into main Aug 25, 2023
@it-vegard it-vegard deleted the bugfix/should-not-have-simultaneous-hover-and-focused-option-in-combobox branch August 25, 2023 11:34
@github-actions github-actions bot mentioned this pull request Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] To options kan få fokus om man benytter mus og tastatur på samme tid
2 participants