✨ Modal: mulighet for å rendre i portal #2209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d4750a3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Storybook demoEndringer til review: 1de98c8af3 | 48 komponenter | 320 stories |
KenAJoh
approved these changes
Aug 24, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kunne ikke skille ut portal i egen komponent likevel, fordi alle useEffect-ene må ha portalNode som dep for at de skal bli kjørt igjen når modalen er rendra. La til noen kommentarer om det i koden også.
En kostnad med å bruke useFloatingPortalNode er at det blir en ekstra render når modalen mounter. Men det er nødvendig for at det skal funke optimalt med SSR. Alternativet er å kun bruke createPortal, men da kan vi enten ikke støtte SSR, eller støtte det men rendre "inline" (i stedet for portal) på serversiden.