Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 GuidePanel: justert design #2227

Merged
merged 7 commits into from
Sep 1, 2023
Merged

💄 GuidePanel: justert design #2227

merged 7 commits into from
Sep 1, 2023

Conversation

HalvorHaugan
Copy link
Contributor

@HalvorHaugan HalvorHaugan commented Aug 30, 2023

Closes https://github.com/navikt/team-aksel/issues/203

Justeringer ihht. Figma. Blir small automatisk på mobil. Blir også poster på mobil, men bare hvis du ikke har definert poster=true/false.

@changeset-bot
Copy link

changeset-bot bot commented Aug 30, 2023

🦋 Changeset detected

Latest commit: a406571

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@navikt/ds-react Patch
@navikt/ds-css Patch
@navikt/aksel-stylelint Patch
@navikt/aksel Patch
@navikt/ds-tokens Patch
@navikt/ds-tailwind Patch
@navikt/aksel-icons Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 30, 2023

Storybook demo

Endringer til review: 6

60ba4848a | 54 komponenter | 356 stories

@KenAJoh
Copy link
Collaborator

KenAJoh commented Aug 31, 2023

Mest en design-critique, men er noe med bruk av info-fargen som ikke fungerer helt for denne komponenten. Er kanskje mest border-fargen som ikke har kontrasten fra bakgrunnsfargen å lene seg på som i f.eks Alert 🤔 Vet det bryter med "info"-semantikken, men denne komponenten er kanskje mest dekorasjon (?). Tester alt-3 fargen her:
Screenshot 2023-08-31 at 09 07 30

@KenAJoh
Copy link
Collaborator

KenAJoh commented Aug 31, 2023

Brand-spørsmål
Screenshot 2023-08-31 at 09 07 30
Kan logoen her byttes ut med nye digital versjon. Får da plass til en litt større logo som er litt tydeligere

Copy link
Collaborator

@KenAJoh KenAJoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@HalvorHaugan HalvorHaugan merged commit 960a082 into main Sep 1, 2023
@HalvorHaugan HalvorHaugan deleted the guidepanel-responsive branch September 1, 2023 10:43
@github-actions github-actions bot mentioned this pull request Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants